netdev - Re: [PATCH] Removal of debug code containing deprecated calls to cli()/sti()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080418190729.GE20637@parisc-linux.org>
Date:	Fri, 18 Apr 2008 13:07:29 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Mark Asselstine <mark.asselstine@...driver.com>
Cc:	kernel-janitors@...r.kernel.org, chas@....nrl.navy.mil,
	netdev@...r.kernel.org, asselsm@...il.com
Subject: Re: [PATCH] Removal of debug code containing deprecated calls to cli()/sti()

On Fri, Apr 18, 2008 at 02:36:46PM -0400, Mark Asselstine wrote:
> -   ns_grab_res_lock(card, flags);
> +   spin_lock_irqsave(&(card)->res_lock,(flags));

We generally prefer the form:

	spin_lock_irqsave(&card->res_lock, flags);

The brackets aren't needed and since they aren't used elsewhere in the
kernel, breaking the pattern makes it look like these are somehow
different (which they aren't).

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html