netdev - Re: [patch] document hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080419175739.GA13774@elf.ucw.cz>
Date:	Sat, 19 Apr 2008 19:57:40 +0200
From:	Pavel Machek <pavel@....cz>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	hidave.darkstar@...il.com, linux-bluetooth@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [patch] document hci_usb as broken

Hi!

>> index 075598e..20d9279 100644
>> --- a/drivers/bluetooth/Kconfig
>> +++ b/drivers/bluetooth/Kconfig
>> @@ -3,13 +3,16 @@ menu "Bluetooth device drivers"
>> 	depends on BT
>>
>> config BT_HCIUSB
>> -	tristate "HCI USB driver"
>> +	tristate "HCI USB driver (dangerous, use alternate driver below)"
>> 	depends on USB
>> 	help
>> 	  Bluetooth HCI USB driver.
>> 	  This driver is required if you want to use Bluetooth devices with
>> 	  USB interface.
>>
>> +	  Unfortunately, locking in this driver is fatally broken; it will
>> +	  corrupt memory on surprise disconnect and during resume.
>> +
>> 	  Say Y here to compile support for Bluetooth USB devices into the
>> 	  kernel or say M to compile it as module (hci_usb).
>
> this would be fine with me. Acked-by: Marcel Holtmann <marcel@...tmann.org>
>
>> diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
>> index 192522e..6cc96b4 100644
>> --- a/drivers/bluetooth/hci_usb.c
>> +++ b/drivers/bluetooth/hci_usb.c
>> @@ -1,8 +1,22 @@
>> -/*
>> +/*
>> +
>> +    This driver has fatally broken locking.
>> +
>> +    DO NOT USE.
>> +
>> +    See btusb.c for cleaner / shorter / actually working driver.
>
> NAK to this hunk. Not needed. The Kconfig help is enough.

Developers trying to debug hci_usb problems will nor see the help
text, since they probably have it enabled in their .config already and
will not be asked again...

								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html