lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080420.030141.07052649.davem@davemloft.net>
Date:	Sun, 20 Apr 2008 03:01:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ivdoorn@...il.com
Cc:	mingo@...e.hu, linville@...driver.com, tomas.winkler@...el.com,
	linux-kernel@...r.kernel.org, kaber@...sh.net,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	mabbas@...ux.intel.com, ischram@...enet.be, rjw@...k.pl
Subject: Re: [build bug] drivers/built-in.o: In function
 `rt2x00leds_resume': : undefined reference to `led_classdev_resume'

From: David Miller <davem@...emloft.net>
Date: Sun, 20 Apr 2008 02:47:04 -0700 (PDT)

> I think NEW_LEDS can be completely eliminated.

Actually, more accurately, I propose removing the HAS_IOMEM
restriction.

This allows LEDS infrastructure to be select'd by drivers safely.

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 859814f..91d36d0 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -1,6 +1,5 @@
 menuconfig NEW_LEDS
 	bool "LED Support"
-	depends on HAS_IOMEM
 	help
 	  Say Y to enable Linux LED support.  This allows control of supported
 	  LEDs from both userspace and optionally, by kernel events (triggers).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ