netdev - Re: [bug] build failure in net/netfilter/nf_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080419.175405.91059921.davem@davemloft.net>
Date:	Sat, 19 Apr 2008 17:54:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: [bug] build failure in net/netfilter/nf_conntrack_sip.c, on
 latest -git

From: Patrick McHardy <kaber@...sh.net>
Date: Sat, 19 Apr 2008 18:38:41 +0200

> David Miller wrote:
> > From: Ingo Molnar <mingo@...e.hu>
> > Date: Sat, 19 Apr 2008 12:00:35 +0200
> >
> > [ netfilter-devel and netdev added to CC: ]
> >
> >   
> >> randconfig testing found a netfilter build failure in latest -git:
> >>
> >>   net/netfilter/nf_conntrack_sip.c: In function 'set_expected_rtp_rtcp':
> >>   net/netfilter/nf_conntrack_sip.c:786: error: 'struct nf_conntrack_expect' has no member named 'saved_ip'
> >>
> >>   http://redhat.com/~mingo/misc/config-Sat_Apr_19_11_37_02_CEST_2008.bad
> >>
> >> disabling CONFIG_NF_CONNTRACK_SIP works it around.
> >>     
> >
> > I think this will fix it.
> >
> > Patrick, is this how we should do it?
> 
> No, the SIP helper is also useful without NAT. This patch adds
> an ifdef around the RTP call optimization for NATed clients.
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>

Fair enough, applied, thanks Patrick.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html