| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080420160531.GA26599@electric-eye.fr.zoreil.com> Date: Sun, 20 Apr 2008 18:05:31 +0200 From: Francois Romieu <romieu@...zoreil.com> To: Florian Fainelli <florian.fainelli@...ecomint.eu> Cc: Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org> Subject: [PATCH 1/2] korina: fix misplaced return statement The driver takes the error unwind path without condition. Signed-off-by: Francois Romieu <romieu@...zoreil.com> --- drivers/net/korina.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/korina.c b/drivers/net/korina.c index 1d24a73..305be62 100644 --- a/drivers/net/korina.c +++ b/drivers/net/korina.c @@ -1031,6 +1031,8 @@ static int korina_open(struct net_device *dev) dev->name, lp->und_irq); goto err_free_ovr_irq; } +out: + return ret; err_free_ovr_irq: free_irq(lp->ovr_irq, dev); @@ -1041,8 +1043,6 @@ err_free_rx_irq: err_release: korina_free_ring(dev); goto out; -out: - return ret; } static int korina_close(struct net_device *dev) -- 1.5.3.3 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists