netdev - [PATCH] 2.6.25 typhoon_resume - remove call to start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080421044415.GB15080@colo.lackof.org>
Date:	Sun, 20 Apr 2008 22:44:15 -0600
From:	Grant Grundler <grundler@...isc-linux.org>
To:	jgarzik@...ox.com, David Dillow <dave@...dillows.org>
Cc:	netdev@...r.kernel.org
Subject: [PATCH] 2.6.25 typhoon_resume - remove call to start_queue

Jeff,

While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952
I looked at a few other drivers to figure out what drivers _should_
be doing for suspend/resume. I noticed typhoon driver is likely doing
more than it needs to.  Patch below is untested since I don't have the HW.

Suspend/resume code across NIC drivers is fairly inconsistent.
And I couldn't find any documentation on what the canonical sequence
NICs need to do for suspend or resume.  Is there any?

Barring contrary advice, I'm going model the tulip suspend/resume
fixes after tg3.c since a number of "modern" (< 5 years old) laptops
have that and I'm silly enough to assume it works.

thanks,
grant

---
Comments/code in netif_device_attach() suggest it is restarting the queue.
Thus, typhoon_resume() doesn't need to call start_queue().

Signed-off-by: Grant Grundler <grundler@...isc-linux.org>

diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index 333961b..c0dd25b 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev)
 	}

 	netif_device_attach(dev);
-	netif_start_queue(dev);
 	return 0;

 reset:
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html