netdev - Re: [2.6 patch] make icmp_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080421094409.GK26897@cs181133002.pp.htv.fi>
Date:	Mon, 21 Apr 2008 12:44:09 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	David Miller <davem@...emloft.net>
Cc:	den@...nvz.org, netdev@...r.kernel.org
Subject: Re: [2.6 patch] make icmp_sk_init() static

On Mon, Apr 21, 2008 at 02:32:26AM -0700, David Miller wrote:
> From: Adrian Bunk <bunk@...nel.org>
>...
> BTW, I noticed that some of your patches get posted like
> this:
> 
> > d163a44e24881d5e960bf9bdc1819ba8ccd15555 diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
> > index f064031..fee171e 100644
> 
> with the commit ID newline missing, so that the diff specification
> shares the same line as the commit ID.
> 
> Oddly some of your patch postings do not have this missing newline.
> 
> Any idea what causes this?  Just curious :-)

I'm using git mainly as a diff generation tool doing
  cg-commit < /dev/null; git-show --pretty=oneline > /tmp/patch-somename

This "commit ID newline missing" seems to be the effect of the 
--pretty=oneline.

Not sure why some postings do have the newline.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html