netdev - Re: [PATCH 2/2] drivers/net: Fix synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Apr 2008 21:04:42 -0400
From:	David Dillow <dave@...dillows.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] drivers/net: Fix synchronize_irq() bugs,
	redundancies


On Mon, 2008-04-21 at 19:35 -0400, Jeff Garzik wrote:
> free_irq() calls synchronize_irq() for you, so there is no need for
> drivers to manually do the same thing (again).  Thus, calls where
> sync-irq immediately precedes free-irq can be simplified.

> diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
> index 333961b..7d2a4c6 100644
> --- a/drivers/net/typhoon.c
> +++ b/drivers/net/typhoon.c
[...]
>  	/* Make sure there is no irq handler running on a different CPU. */
> -	typhoon_synchronize_irq(dev->irq);
>  	free_irq(dev->irq, dev);

Should probably kill the comment as well, since it was referring to the
synchronize_irq() call.

Acked-by: Dave Dillow <dave@...dillows.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html