netdev - mac80211/wme.c: check-after-use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080423095101.GV28933@cs181133002.pp.htv.fi>
Date:	Wed, 23 Apr 2008 12:51:01 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Ron Rindjunsky <ron.rindjunsky@...el.com>,
	"John W. Linville" <linville@...driver.com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: mac80211/wme.c: check-after-use

The Coverity checker spotted the following check-after-use of the 
"qdisc" variable in net/mac80211/wme.c introduced by
commit 9e7234923789897858e1a475c579b5e2e6ad5b74
(mac80211: A-MPDU Tx adding qdisc support):

<--  snip  -->

...
void ieee80211_requeue(struct ieee80211_local *local, int queue)
{
        struct Qdisc *root_qd = local->mdev->qdisc_sleeping;
        struct ieee80211_sched_data *q = qdisc_priv(root_qd);
        struct Qdisc *qdisc = q->queues[queue];
        struct sk_buff *skb = NULL;
        u32 len = qdisc->q.qlen;    <------

        if (!qdisc || !qdisc->dequeue)
                return;
...

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html