netdev - Re: [RFC PATCH net-2.6.26 (Plan B)] [TCP]: Lower stack usage in tcp4_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080424.010236.189297164.davem@davemloft.net>
Date:	Thu, 24 Apr 2008 01:02:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-2.6.26 (Plan B)] [TCP]: Lower stack usage in
 tcp4_seq_show().

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Tue, 22 Apr 2008 18:35:42 +0400

> YOSHIFUJI Hideaki wrote:
> > tcp4_seq_show() eats about 250 bytes.  By using buffer in seq_file
> > directly, it will be reduced around 100 bytes.
> > 
> > One drawback is higher usage of slab for IPv6 but the format
> > will not change with this patch.
> > 
> > Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> 
> Plan C: we can follow the Al Viro's proposal about %n like in this patch.
> The same applies to udp, fib (the /proc/net/route file), rt_cache and 
> sctp debug. This is minus ~150-200 bytes for each.
> 
> How do you think?
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

To me, this looks great.  Thanks everyone for working on this.

Patch applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html