netdev - Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit kernels.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080424.023513.116464364.davem@davemloft.net>
Date:	Thu, 24 Apr 2008 02:35:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	dlstevens@...ibm.com, netdev@...r.kernel.org
Subject: Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit
 kernels.

From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
Date: Thu, 24 Apr 2008 18:28:34 +0900 (JST)

> Most (if not all) compat_XXX{} do not have such attribute,
> and sockaddr_storage{} shuould actually be aligned on 32bit on
> 32bit archs, so I think we should declare, no?
> 
> For example, if we have
>     struct foobar {
>         char a;
>         struct sockaddr_storage b;
>     };
> Then, offsetof(struct foobar, b) should be 4, not 1 nor 2.
> (Of course all other fields of group_xxx structures are of
> u32 here, so it is safe so far...)

You're right, it seems the aligned(4) is the best way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html