netdev - Re: [PATCH 2/2] [NIU] Add support for Neptune FEM/NEM cards for C10 server blades

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080423.183022.52374157.davem@davemloft.net>
Date:	Wed, 23 Apr 2008 18:30:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	matheos.worku@....com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] [NIU] Add support for Neptune FEM/NEM cards for
 C10 server blades

From: Matheos Worku <matheos.worku@....com>
Date: Wed, 23 Apr 2008 10:17:40 -0700

> @@ -3243,6 +3245,7 @@ struct niu {
>  	struct timer_list		timer;
>  	const struct niu_phy_ops	*phy_ops;
>  	int				phy_addr;
> +	int hotplug_phy_present;
>  	struct niu_link_config		link_config;
>  
>  	struct work_struct		reset_task;

Using a full integer for boolean state is wasteful, please
just add another state flag to niu->flags

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html