netdev - Re: [PATCH] [ETHTOOL]: EEPROM dump no longer works for tg3 and natsemi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080424.205750.91351344.davem@davemloft.net>
Date:	Thu, 24 Apr 2008 20:57:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	msb@...gle.com
Cc:	netdev@...r.kernel.org, leitao@...ux.vnet.ibm.com,
	thockin@...gle.com, jeff@...zik.org, joe@...ches.com,
	nil@...gle.com, matthew@....cx
Subject: Re: [PATCH] [ETHTOOL]: EEPROM dump no longer works for tg3 and
 natsemi

From: Mandeep Singh Baines <msb@...gle.com>
Date: Thu, 24 Apr 2008 19:20:30 -0700

> In the ethtool user-space application, tg3 and natsemi over-ride the default
> implementation of dump_eeprom(). In both tg3_dump_eeprom() and
> natsemi_dump_eeprom(), there is a magic number check which is not present in
> the default implementation.
> 
> Commit b131dd5d snipped the code which copied the ethtool_eeprom structure
> back to user-space. tg3 and natsemi are over-writing the magic number field
> and then checking it in user-space. With the ethtool_eeprom copy removed, the
> check is failing.
> 
> The fix is simple. Add the ethtool_eeprom copy back.
> 
> Signed-off-by: Mandeep Singh Baines <msb@...gle.com>

Patch applied, thank you for fixing this bug.

Could you make a minor modification to your changelog comments
in the future?  When referencing an SHA ID commit, please include
the header text line from the changelog.  In this way, if the
commit ID changes for whatever reason, people can still figure out
what commit you're referencing.

For example, I changed your second paragraph to read:

--------------------
    Commit b131dd5d ("[ETHTOOL]: Add support for large eeproms") snipped
    the code which copied the ethtool_eeprom structure back to
    user-space. tg3 and natsemi are over-writing the magic number field
    and then checking it in user-space. With the ethtool_eeprom copy
    removed, the check is failing.
--------------------

when I added your change.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html