netdev - Re: [PATCH 1/8] e1000e: cleanup several stats issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <481173B9.3010006@garzik.org>
Date:	Fri, 25 Apr 2008 02:01:29 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 1/8] e1000e: cleanup several stats issues

Auke Kok wrote:
> From: Bruce Allan <bruce.w.allan@...el.com>
> 
> Several stats registers are completely unused and we just waste pci
> bus time reading them. We also omit using the high 32 bits of the GORC/
> GOTC counters. We can just read clear them and only read the low registers.
> 
> Mii-tool can also break es2lan if it executes a MII PHY register
> ioctl while the device is in autonegotiation. Unfortunately it seems
> that several applications and installations still perform this ioctl
> call periodically and especially in this crucial startup time. We
> can fool the ioctl by providing fail safe information that mimics
> the "down" link state and only perform the dangerous PHY reads once
> after link comes up to fill in the real values. As long as link
> stays up the information will not change.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>

applied 1-8

I was mainly waiting for the discussion of the abuse of the ethtool 
interface, which I chose to allow.

Now, send me a patch to the ethtool man page for this new behavior :)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html