netdev - Re: [PATCH v2.6.26] gianfar: Fix skb allocation strategy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48117464.4060301@pobox.com>
Date:	Fri, 25 Apr 2008 02:04:20 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Andy Fleming <afleming@...escale.com>
CC:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2.6.26] gianfar: Fix skb allocation strategy

Andy Fleming wrote:
> gianfar was unable to handle failed skb allocation for rx buffers, so
> we were spinning until it succeeded.  Actually, it was worse--we were
> spinning for a long time, and then silently failing.  Instead, we take
> Stephen Hemminger's suggestion to try the allocation earlier, and drop the
> packet if it failed.
> 
> We also make a couple of tweaks to how buffer descriptors are set up.
> 
> Signed-off-by: Andy Fleming <afleming@...escale.com>

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html