netdev - Re: [XFRM]: alg_key_len & alg_icv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080425071419.GA17997@gondor.apana.org.au>
Date:	Fri, 25 Apr 2008 15:14:20 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [XFRM]: alg_key_len & alg_icv_len should be unsigned

On Fri, Apr 25, 2008 at 09:09:05AM +0200, Eric Dumazet wrote:
> In commit ba749ae98d5aa9d2ce9a7facde0deed454f92230 ([XFRM]: alg_key_len 
> should be unsigned to avoid integer divides 
> <http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=ba749ae98d5aa9d2ce9a7facde0deed454f92230>) 
> alg_key_len field of struct xfrm_algo was converted to unsigned int to 
> avoid integer divides.
> 
> Then Herbert in commit 1a6509d991225ad210de54c63314fd9542922095 
> ([IPSEC]: Add support for combined mode algorithms) added a new 
> structure xfrm_algo_aead, that resurrected a signed int for alg_key_len 
> and re-introduce integer divides.
> 
> This patch avoids these divides and saves 64 bytes of text on i386.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

I actually wrote my patch before yours was merged which was why
it was signed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html