netdev - Re: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080425.002636.250010462.davem@davemloft.net>
Date:	Fri, 25 Apr 2008 00:26:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	seraph@...all.nl, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, bugme-daemon@...zilla.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI) -
 network device doesn't work

From: Jarek Poplawski <jarkao2@...il.com>
Date: Wed, 2 Apr 2008 20:26:55 +0200

> Nice work Jos! I forward it to the author and the lists.

I haven't forgotten about this bug report, in fact I did some
investigation and thinking about it.

I think the case being triggered in the new code is IRQ_DISABLED.

If this is the problem, I suspect that what needs to happen is that
when we re-enable the interrupt we have to forcefully hit the clear
register to put it back into transmit state.  Otherwise it can
get stuck.

Please give this patch a try (this is against 2.6.23, which is the
version you reported the bug against, let me know if another version
is more convenient).

Thanks!

diff --git a/arch/sparc64/kernel/irq.c b/arch/sparc64/kernel/irq.c
index 2395609..98b68d2 100644
--- a/arch/sparc64/kernel/irq.c
+++ b/arch/sparc64/kernel/irq.c
@@ -313,6 +313,8 @@ static void sun4u_irq_enable(unsigned int virt_irq)
 			 IMAP_AID_SAFARI | IMAP_NID_SAFARI);
 		val |= tid | IMAP_VALID;
 		upa_writeq(val, imap);
+
+		upa_writeq(ICLR_IDLE, data->iclr);
 	}
 }

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html