netdev - Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit kernels.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080425.230116.234973563.davem@davemloft.net>
Date:	Fri, 25 Apr 2008 23:01:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	dlstevens@...ibm.com, netdev@...r.kernel.org
Subject: Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit
 kernels.

From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
Date: Sat, 26 Apr 2008 14:56:11 +0900 (JST)

> In article <20080425.223236.81693355.davem@...emloft.net> (at Fri, 25 Apr 2008 22:32:36 -0700 (PDT)), David Miller <davem@...emloft.net> says:
> 
> > From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
> > Date: Sat, 26 Apr 2008 13:53:37 +0900 (JST)
> > 
> > > In article <OF326F3AF9.7322F5FB-ON88257437.00174874-88257437.00194F7B@...ibm.com> (at Fri, 25 Apr 2008 21:36:29 -0700), David Stevens <dlstevens@...ibm.com> says:
> > > 
> > > > > net/compat.c is not the right place.
> > > > > Please put this in net/ipv4/compat.c or so.
> > > > > Or at least, these must be guarded by CONFIG_INET.
> > > > 
> > > >         This code is for both v4 and v6, so I'd rather it not be in
> > > > net/ipv4/compat.c. I didn't try without CONFIG_INET, -- will look
> > > > at that.
> > > 
> > > We've been putting ipv4/ipv6 common things in net/ipv4/*.c,
> > > so please put it in net/ipv4/compat.c.
> > 
> > I see no reason not to put this in net/compat.c, it's acting
> > like fs/compat_ioctl.c which even has networking compat
> > ioctls implemented there, among other things ;-)
> 
> Okay

Actually, it is a problem.  I take back what I said.

There is no easy way to call into the ipv6 code from
this built-in code if IPV6 is built modular.

So it really does have to go into ipv4 and ipv6 subdirectories,
respectively.

David, please make this adjustment.  Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html