netdev - Re: [Patch]net/xfrm/xfrm_policy.c: replace timer with delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080427011809.GA662@gondor.apana.org.au>
Date:	Sun, 27 Apr 2008 09:18:09 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...l.org>, netdev@...r.kernel.org
Subject: Re: [Patch]net/xfrm/xfrm_policy.c: replace timer with delayed_work

On Sat, Feb 16, 2008 at 11:55:34PM +0800, WANG Cong wrote:
> 
> As suggested by Herbert, using workqueue is better than timer
> for net/xfrm/xfrm_policy.c, so replace them with delayed_work.
> 
> Note that, this patch is not fully tested, just compile and
> run as a whole on an Intel Core Duo matchine. So should be
> in -mm first.
> 
> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: David Miller <davem@...emloft.net>

Sorry for the extremely long delay, but I've finally made it
to this email in my backlog :)

The patch looks OK except for one thing, the read-write spin
lock needs to disable BH now that it's moved to process context.
Otherwise we'll get dead-locks with the softirq path taking the
same lock.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html