netdev - Re: [PATCH] asm/unaligned.h doesn't work well as the very first include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080427060944.GB9199@uranus.ravnborg.org>
Date:	Sun, 27 Apr 2008 08:09:44 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] asm/unaligned.h doesn't work well as the very first include

On Sun, Apr 27, 2008 at 06:19:18AM +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
>  net/mac80211/mesh.h      |    1 +
>  net/mac80211/mesh_hwmp.c |    1 -
>  2 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
> index 742003d..9ee3aff 100644
> --- a/net/mac80211/mesh.h
> +++ b/net/mac80211/mesh.h
> @@ -13,6 +13,7 @@
>  
>  #include <linux/types.h>
>  #include <linux/jhash.h>
> +#include <asm/unaligned.h>
>  #include "ieee80211_i.h"
>  
>  
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index 02de8f1..3df8092 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -7,7 +7,6 @@
>   * published by the Free Software Foundation.
>   */
>  
> -#include <asm/unaligned.h>
>  #include "mesh.h"

It has been discussed that any .h file should pull
in what it needs so the other of includes does not matter.
Some do them alphabetically.

Why not fix asm-*/unaligned.h so all users now and future
are fixed in one shot?

	Sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html