netdev - Re: Slab Corruption with ipv6 and tcp6fuzz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080427153211.GA6182@alice>
Date:	Sun, 27 Apr 2008 17:32:11 +0200
From:	Eric Sesterhenn <snakebyte@....de>
To:	Patrick McManus <mcmanus@...ksong.com>
Cc:	David Miller <davem@...emloft.net>, johnpol@....mipt.ru,
	netdev@...r.kernel.org, ilpo.jarvinen@...sinki.fi,
	dada1@...mosbay.com
Subject: Re: Slab Corruption with ipv6 and tcp6fuzz

* Patrick McManus (mcmanus@...ksong.com) wrote:
> I'll take a look asap - thanks for the cc:, I've been away.

Evgeniys patch fixes the issue for me and i see no more corruptions.

Eric 

> > > Ok, I can not reproduce it, so lets try hard way.
> > > Can you test attached patch, its idea is described above and I checked
> > > multiple times, that it is forbidden to free skb and return non-zero
> > > value from tcp_rcv_established(). This behaviour was introduced with TCP
> > > defer accept changes in 2.6.25 with
> > > ec3c0982a2dd1e671bad8e9d26c28dcba0039d87 commit.
> > > 
> > > Please test. This bug affects both ipv6 and ipv4 code actually.
> > > 
> > > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> > > index ac9b848..0298f80 100644
> > > --- a/net/ipv4/tcp_input.c
> > > +++ b/net/ipv4/tcp_input.c
> > > @@ -4925,8 +4925,7 @@ step5:
> > >  	tcp_data_snd_check(sk);
> > >  	tcp_ack_snd_check(sk);
> > >  
> > > -	if (tcp_defer_accept_check(sk))
> > > -		return -1;
> > > +	tcp_defer_accept_check(sk);
> > >  	return 0;
> > >  
> > >  csum_error:
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html