netdev - Re: [PATCH][NET_SCHED] sch_sfq: prevent unnecessary reordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080428.020356.105209144.davem@davemloft.net>
Date:	Mon, 28 Apr 2008 02:03:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_sfq: prevent unnecessary reordering

From: Jarek Poplawski <jarkao2@...il.com>
Date: Mon, 28 Apr 2008 09:04:53 +0000

> On 27-04-2008 16:22, Jarek Poplawski wrote:
> > [NET_SCHED] sch_sfq: fix queue limiting while enqueuing
> > 
> 
> David, as Patrick noticed this patch was wrong and I withdraw it.

Yes, I was following the discussion.  But thanks for the
confirmation :-)

> I still can't see why sfq should have such a low limit, but I think,
> there is at least something to improve in the way it's imposed. BTW,
> my previous idea to check this before classifying was wrong too. But,
> IMHO, this could be done better than now like in this patch.
 ...
> [NET_SCHED] sch_sfq: prevent unnecessary reordering
> 
> Current check of queue limit in sfq_enqueue() isn't optimal: there
> is really not much more needed to prevent unnecessary dropping and
> possible reordering.
> 
> 
> Signed-off-by: Jarek Poplawski <jarkao2@...il.com>

I'll let Patrick review this one first, too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html