lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Apr 2008 23:10:17 +0900 (JST) From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> To: satoru.satoh@...il.com Cc: netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org Subject: Re: [PATCH] Use inline function dst_metric() instead of direct access to dst->metric[] In article <4815D81F.5090404@...il.com> (at Mon, 28 Apr 2008 22:58:55 +0900), Satoru SATOH <satoru.satoh@...il.com> says: > > > There are functions to refer to the value of dst->metric[THE_METRIC-1] directly > without use of a inline function "dst_metric" defined in net/dst.h. > > The following patch changes them to use the inline function consistently. Sato-san, I think we have more places, e.g., in net/ipv4/route.c: if (rt->u.dst.metrics[RTAX_HOPLIMIT-1] == 0) should be converted as if (dst_metric(&rt->u.dst, RTAX_HOPLIMIT) == 0) Could you annotate those as well, please? Maybe we could introduce dst_metric_set(), but it is a different issue. --yoshfuji -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists