netdev - Re: [PATCH] add compat support for getsockopt (MCAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080428.153650.57555735.yoshfuji@linux-ipv6.org>
Date:	Mon, 28 Apr 2008 15:36:50 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	dlstevens@...ibm.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] add compat support for getsockopt (MCAST_MSFILTER)

In article <OFCC2BF571.D815BBAC-ON88257439.001DC6D6-88257439.001F49AD@...ibm.com> (at Sun, 27 Apr 2008 23:41:51 -0600), David Stevens <dlstevens@...ibm.com> says:

> This patch adds support for getsockopt for MCAST_MSFILTER for
> both IPv4 and IPv6. It depends on the previous setsockopt patch,
> and uses the same method. In addition, there are these cleanups
> included for the setsockopt patch:
> 
> 1) added missing "__user" for kgsr and kgf pointers
> 2) verify read for only GROUP_FILTER_SIZE(0). The group_filter
>         structure definition (via RFC) includes space for one source
>         in the source list array, but that source need not be present.
>         So, sizeof(group_filter) > GROUP_FILTER_SIZE(0). Fixed
>         the user read-check for minimum length to use the smaller size.
> 3) remove unneeded "&" for gf_slist addresses

IMHO, It's much better to split into 2 pathces - bug fixes and
getsockopt() support...

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html