netdev - Re: [PATCH 1/4] virtio: wean net driver off NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080429050616.GA17840@gondor.apana.org.au>
Date:	Tue, 29 Apr 2008 13:06:16 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] virtio: wean net driver off NETDEV_TX_BUSY

On Tue, Apr 29, 2008 at 01:16:05AM +1000, Rusty Russell wrote:
>
> +	/* If we has a buffer left over from last time, send it now. */
> +	if (vi->last_xmit_skb) {
> +		if (xmit_skb(vi, vi->last_xmit_skb) != 0) {
> +			/* Drop this skb: we only queue one. */
> +			kfree_skb(skb);
> +			goto stop_queue;

We should increment the drop counter here.

Otherwise these patches all look good to me.

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html