netdev - Re: [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Apr 2008 22:53:41 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing

On Mon, Apr 28, 2008 at 04:58:37PM +0200, Jarek Poplawski wrote:
...
> Yes, a new parameter looks like the safest choice. I'll only have to
> re-think first the possible reason for this strange limit...

  
static inline void sfq_link(struct sfq_sched_data *q, sfq_index x)
{
	sfq_index p, n;
	int d = q->qs[x].qlen + SFQ_DEPTH;
-------------------->^^^^^^^^

	p = d;
	n = q->dep[d].next;
...

So it's really by design! (I don't know why I missed this, and why
it didn't break my lame test...)

Thanks again for stopping this disaster,
Jarek P. 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html