netdev - Re: [PATCH] net: eepro autoport typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4816B937.8020503@garzik.org>
Date:	Tue, 29 Apr 2008 01:59:19 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	David Miller <davem@...emloft.net>,
	linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: eepro autoport typo

Harvey Harrison wrote:
> Found by sparse dubious !x & y warning...hidden in the GetBit macro
> why !Word doesn't make any sense.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
>  drivers/net/eepro.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/eepro.c b/drivers/net/eepro.c
> index 83bda6c..56f5049 100644
> --- a/drivers/net/eepro.c
> +++ b/drivers/net/eepro.c
> @@ -633,7 +633,7 @@ static void __init printEEPROMInfo(struct net_device *dev)
>  		printk(KERN_DEBUG " PC: %d\n", GetBit(Word,ee_PC));
>  		printk(KERN_DEBUG " TPE/AUI: %d\n", GetBit(Word,ee_TPE_AUI));
>  		printk(KERN_DEBUG " Jabber: %d\n", GetBit(Word,ee_Jabber));
> -		printk(KERN_DEBUG " AutoPort: %d\n", GetBit(!Word,ee_Jabber));
> +		printk(KERN_DEBUG " AutoPort: %d\n", !GetBit(Word,ee_AutoPort));
>  		printk(KERN_DEBUG " Duplex: %d\n", GetBit(Word,ee_Duplex));

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html