netdev - Re: [PATCH v2.6.26 2/2] gianfar: Determine TBIPA value dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4816B9A8.8080905@pobox.com>
Date:	Tue, 29 Apr 2008 02:01:12 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	netdev@...r.kernel.org, Andy Fleming <afleming@...escale.com>
Subject: Re: [PATCH v2.6.26 2/2] gianfar: Determine TBIPA value dynamically

Paul Gortmaker wrote:
> In message: Re: [PATCH v2.6.26 2/2] gianfar: Determine TBIPA value dynamically
> on 16/04/2008 Jeff Garzik wrote:
> 
>> ACK, but failed to apply
>>
>> please rediff against jgarzik/netdev-2.6.git#upstream or its parent,  
>> davem/net-2.6.26.git
> 
> Re-diffed against davem/net-2.6.26.git -- this minor change in the context:
> 
> -#define DEFAULT_RXTIME 4
> +#define DEFAULT_RXTIME 21
> 
> overlapped with this patch and caused git to get upset about fuzz.
> Other than this context change, the patch is identical to what you've
> already reviewed.
> 
> Thanks,
> Paul.
> ---
> 
>  From 1f78c8a708b5424fdba33320591258a033f079cd Mon Sep 17 00:00:00 2001
> From: Paul Gortmaker <paul.gortmaker@...driver.com>
> Date: Tue, 15 Apr 2008 12:23:21 -0400
> Subject: [PATCH] gianfar: Determine TBIPA value dynamically
> 
> TBIPA needs to be set to a value (on connected MDIO buses) that doesn't
> conflict with PHYs on the bus.  By hardcoding it to 0x1f, we were preventing
> boards with PHYs at 0x1f from working properly.  Instead, scan the bus when
> it comes up, and find an address that doesn't have a PHY on it.  The TBI PHY
> configuration code then trusts that the value in TBIPA is either safe, or
> doesn't matter (ie - it's not an active bus with other PHYs).
> 
> Signed-off-by: Andy Fleming <afleming@...escale.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html