netdev - Re: [PATCH 2/2] bridge: kernel panic when unloading bridge module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080429.031823.214117840.davem@davemloft.net>
Date:	Tue, 29 Apr 2008 03:18:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org, bstroesser@...itsu-siemens.com
Subject: Re: [PATCH 2/2] bridge: kernel panic when unloading bridge module

From: Stephen Hemminger <shemminger@...tta.com>
Date: Mon, 28 Apr 2008 17:29:07 -0700

> There is a race condition when unloading bridge and netfilter.
> 
> The problem happens if __fake_rtable is in use by a skb
> coming in, while someone starts to unload bridge.ko.
> br_netfilter_fini() is called at the beginning of unload
> in br_deinit() while skbs still are being forwarded and
> transferred to local ip stack. Thus there is a possibility
> of the __fake_rtable pointer not being removed in a skb that
> goes up to ip stack. This results in a kernel panic, as
> ip_rcv() calls the input-function of __fake_rtable, which
> is NULL.
> 
> Moving the call of br_netfilter_fini() to the end of
> br_deinit() solves the problem.
> 
> Signed-off-by: Bodo Stroesser <bstroesser@...itsu-siemens.com>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@...tta.com>

Also applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html