netdev - [PATCH 0/8][BONDING]: Some BUGs and deadlocks fixes and a bit of concomitant cleanups.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <481735F4.30909@openvz.org>
Date:	Tue, 29 Apr 2008 18:51:32 +0400
From:	Pavel Emelyanov <xemul@...nvz.org>
To:	Jay Vosburgh <fubar@...ibm.com>, David Miller <davem@...emloft.net>
CC:	bonding-devel@...ts.sourceforge.net,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: [PATCH 0/8][BONDING]: Some BUGs and deadlocks fixes and a bit of
 concomitant cleanups.

Hi Jay, Dave.

While looking at the bonding driver I found four bugs visible with
the unaided eye. Here are the fixes, but I also cleaned up some
places, I just couldn't come by. If you consider those cleanups to
be for next merge window, just kick me and I'll resubmit this set
without them.

Found BUGs summary:
1. Bad error path in bond_create - the registered device should
   not be released with free_netdev;
2. Specifying the 'bond%d' name when creating a new device results
   in a new device with literally 'bond%d' name, not bond<digit>
   like for other drivers;
3. Lost unlock of rtnl and bonding_rwsem in bonding_store_bonds;
4. Deadlock between bonding_store_bonds and bond_destroy_sysfs
   on module unload.

The clean ups are
1. Minor alloc_netdev consolidation after fix #2
2. Redundant 3rd argument for bond_create;
3. Unneeded _safe list iterations in some places;
4. Unneeded list_empty checks in some places.

Details in patches.

Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html