netdev - Re: [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48181816.2050904@trash.net>
Date:	Wed, 30 Apr 2008 08:56:22 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
CC:	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>, jeff@...zik.org,
	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device

Patrick McHardy wrote:
> Waskiewicz Jr, Peter P wrote:
>>> In any case I would prefer to avoid having drivers mess with VLAN
>>> device flags. How about adding a device flag indicating that the
>>> driver supports TSO + VLAN acceleration and using the
>>> NETDEV_FEAT_CHANGE notification inside the VLAN code do adjust
>>> the device's flags properly?
>>
>> I've been looking into this, and I agree this makes sense when creating
>> a new VLAN to get the device flags to the VLAN device.  However, we need
>> to get the TSO and/or Tx checksum offload feature flags off all VLAN
>> devices when the parent device has it turned off.  I don't see any clean
>> way of doing this with netdev_features_change().  I'd really love to
>> implement this correctly, so if you have any ideas on how to handle this
>> latter case, I'm all ears.  :-)
> 
> 
> Whats the problem with doing:
> 
> - on VLAN creation: copy VLAN flag from lower device if lowerdev
                            ^^^^ TSO/checksumming flags
>   has NETIF_F_<flag indicating non-broken TSO+VLAN accel>
> 
> - on change of TSO/checksumming flags of lower device:
>   use netdevice notifier to adjust the settings for all
>   VLANs on that device
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html