netdev - Re: [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48181BE3.6040407@trash.net>
Date:	Wed, 30 Apr 2008 09:12:35 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing

Jarek Poplawski wrote:
> On Tue, Apr 29, 2008 at 10:53:41PM +0200, Jarek Poplawski wrote:
> ...
>> So it's really by design! (I don't know why I missed this, and why
> 
> ...Hmm..., actually this is the place:
> 
> sfq_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> {
> ...
> 	x = q->ht[hash];
> 	if (x == SFQ_DEPTH) {
> 		q->ht[hash] = x = q->dep[SFQ_DEPTH].next;
> ...
> 
> sfq counts on free slot always available here.


IIRC thats why the limit is capped at SFQ_DEPTH - 1.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html