netdev - Re: [PATCH 0/2] Disable forwarding of LRO skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080501103854.GA7285@gondor.apana.org.au>
Date:	Thu, 1 May 2008 18:38:54 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	bhutchings@...arflare.com, kmansley@...arflare.com,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] Disable forwarding of LRO skbs

On Thu, May 01, 2008 at 03:34:14AM -0700, David Miller wrote:
> From: Herbert Xu <herbert@...dor.apana.org.au>
> Date: Thu, 01 May 2008 18:19:54 +0800
> 
> > This patch completely breaks forwarding of GSO packets in a
> > virtualised environment where we explicitly want to forward
> > them as is to reduce per-packet overhead.  So if LRO is causing
> > problems then I suggest we find a better way around that that
> > does not penalise all forms of GSO.
> 
> I assume you mean forwarding via a bridge?

Not necessarily.  For example we could be forwarding in a guest
that's acting as a firewall appliance for other guests.

> I think we'll need to add a device attribute for what
> you want.

I still don't understand why we can't forward LRO packets.  It
should be no different to forwarding GSO packets if it's properly
constructed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html