netdev - Re: [PATCH 0/2] Disable forwarding of LRO skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080501111247.GA7756@gondor.apana.org.au>
Date:	Thu, 1 May 2008 19:12:47 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Kieran Mansley <kmansley@...arflare.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, davem@...emloft.net,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] Disable forwarding of LRO skbs

On Thu, May 01, 2008 at 12:08:48PM +0100, Kieran Mansley wrote:
>
> Yes, everything works fine in that case.  It's only when LRO packets are
> forwarded to another physical interface that things go wrong.  

Now this is definitely broken because it fiddles with TCP packets
in the middle, but still it should *work* in as much as making the
packet go out.  Well except that you need to fix up the checksum
so that it only contains the pseudo-header on output.  That's
probably what you need to address if we failed in avoiding LRO
on forwarded traffic.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html