[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <71d336490805010943s79f01e01u9b4566165c4fba3f@mail.gmail.com>
Date: Thu, 1 May 2008 22:13:08 +0530
From: "Ramachandra K" <ramachandra.kuchimanchi@...gic.com>
To: "Stephen Hemminger" <shemminger@...tta.com>
Cc: netdev@...r.kernel.org, rdreier@...co.com,
"Poornima Kamath (Contractor - )" <poornima.kamath@...gic.com>,
general@...ts.openfabrics.org,
"Amar Mudrankit (Contractor - )" <amar.mudrankit@...gic.com>
Subject: [RESEND] RE: [PATCH 08/13] QLogic VNIC: sysfs interface implementation for the driver
Sorry for the resend. Original mail got bounced from netdev.
On Thu, May 1, 2008 at 9:32 PM, <ramachandra.kuchimanchi@...gic.com> wrote:
>
> Stephen,
>
>
> Stephen Hemminger [mailto:shemminger@...tta.com] wrote:
>
> >> On Wed, 30 Apr 2008 22:49:55 +0530
> >> Ramachandra K <ramachandra.kuchimanchi@...gic.com> wrote:
>
> <snip>
>
>
> >> +static match_table_t vnic_opt_tokens = {
> >> + {VNIC_OPT_IOC_GUID, "ioc_guid=%s"},
> >> + {VNIC_OPT_DGID, "dgid=%s"},
> >> + {VNIC_OPT_PKEY, "pkey=%x"},
> >> + {VNIC_OPT_NAME, "name=%s"},
> >> + {VNIC_OPT_INSTANCE, "instance=%d"},
> >> + {VNIC_OPT_RXCSUM, "rx_csum=%s"},
> >> + {VNIC_OPT_TXCSUM, "tx_csum=%s"},
> >> + {VNIC_OPT_HEARTBEAT, "heartbeat=%d"},
> >> + {VNIC_OPT_IOC_STRING, "ioc_string=\"%s"},
> >> + {VNIC_OPT_IB_MULTICAST, "ib_multicast=%s"},
> >> + {VNIC_OPT_ERR, NULL}
> >> +};
> >>
>
> > NO
> > 1. Most of this shouldn't be done via sysfs (rx_csum, tx_csum, ...)
> > 2. Sysfs is one value per file not name=value
>
> The VNIC driver needs multiple parameters (IOCGUID, DGID etc) from user space
> to connect to the EVIC. For this the "name=value" mechanism is used for
> a write-only sysfs file as an input method to the driver.
>
> The driver follows the one value per file sysfs rule when it returns any data
> with each readable file returning only a single value.
>
> Regards,
> Ram
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists