netdev - Re: [PATCH] fs_enet: Fix a memory leak in fs_enet_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080502113744.77e81c7d.akpm@linux-foundation.org>
Date:	Fri, 2 May 2008 11:37:44 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Scott Wood <scottwood@...escale.com>
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH] fs_enet: Fix a memory leak in fs_enet_mdio_probe

On Fri, 2 May 2008 13:31:18 -0500 Scott Wood <scottwood@...escale.com> wrote:

> There are more memory leaks in the !PPC_CPM_NEW_BINDING case, but that code
> will disappear soon along with arch/ppc.
> 
> Signed-off-by: Scott Wood <scottwood@...escale.com>
> ---
>  drivers/net/fs_enet/mii-fec.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
> index ba75efc..f0014cf 100644
> --- a/drivers/net/fs_enet/mii-fec.c
> +++ b/drivers/net/fs_enet/mii-fec.c
> @@ -194,7 +194,7 @@ static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
>  
>  	ret = of_address_to_resource(ofdev->node, 0, &res);
>  	if (ret)
> -		return ret;
> +		goto out_res;
>  
>  	snprintf(new_bus->id, MII_BUS_ID_SIZE, "%x", res.start);
>  
> @@ -236,6 +236,7 @@ out_free_irqs:
>  	kfree(new_bus->irq);
>  out_unmap_regs:
>  	iounmap(fec->fecp);
> +out_res:
>  out_fec:
>  	kfree(fec);
>  out_mii:

It would be nice to credit Daniel Marjamki <danielm77@...ay.se> in the
changelog, please.  Perhaps a mention of
http://bugzilla.kernel.org/show_bug.cgi?id=10591 also.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html