netdev - Re: [net-2.6 patch 1/2][NETNS] fix device renaming for sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080502.170107.107573888.davem@davemloft.net>
Date:	Fri, 02 May 2008 17:01:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dlezcano@...ibm.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-2.6 patch 1/2][NETNS] fix device renaming for sysfs

From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Wed, 30 Apr 2008 23:31:14 +0200

> When a netdev is moved across namespaces with the 'dev_change_net_namespace' 
> function, the 'device_rename' function is used to fixup kobject and refresh 
> the sysfs tree. The device_rename function will call kobject_rename and this
> one will check if there is an object with the same name and this is the case
> because we are renaming the object with the same name.
> 
> The use of 'device_rename' seems for me wrong because we usually don't
> rename it but just move it across namespaces. As we just want to do a 
> mini "netdev_[un]register", IMO the functions 'netdev_[un]register_kobject' 
> should be used instead, like an usual network device [un]registering.
> 
> This patch replace device_rename by netdev_unregister_kobject, followed by
> netdev_register_kobject.
> 
> The netdev_register_kobject will call device_initialize and will raise a 
> warning indicating the device was already initialized. In order to fix that,
> I split the device initialization into a separate function and use it together
> with 'netdev_register_kobject' into register_netdevice. So we can safely call
> 'netdev_register_kobject' in 'dev_change_net_namespace'.
> 
> This fix will allow to properly use the sysfs per namespace which is coming
> from -mm tree.
> 
> Signed-off-by: Daniel Lezcano <dlezcano@...ibm.com>
> Acked-by: Benjamin Thery <benjamin.thery@...l.net>

Looks good, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html