netdev - Re: [PATCH 1/4] bonding: Do not call free_netdev for already registered device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080502.175134.217916824.davem@davemloft.net>
Date:	Fri, 02 May 2008 17:51:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com, xemul@...nvz.org
Subject: Re: [PATCH 1/4] bonding: Do not call free_netdev for already
 registered device.

From: Jay Vosburgh <fubar@...ibm.com>
Date: Fri,  2 May 2008 17:49:37 -0700

> From: Pavel Emelyanov <xemul@...nvz.org>
> 
> If the call to bond_create_sysfs_entry in bond_create fails, the
> proper rollback is to call unregister_netdevice, not free_netdev.
> Otherwise - kernel BUG at net/core/dev.c:4057!
> 
> Checked with artificial failures injected into bond_create_sysfs_entry.
> 
> Pavel's original patch modified by Jay Vosburgh to move code around
> for clarity (remove goto-hopping within the unwind block).
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html