netdev - Re: New driver "sfc" for Solarstorm SFC4000 controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080503200152.GO14219@solarflare.com>
Date:	Sat, 3 May 2008 21:01:56 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Michael Brown <mbrown@...systems.co.uk>
Cc:	netdev@...r.kernel.org
Subject: Re: New driver "sfc" for Solarstorm SFC4000 controller.

Michael Brown wrote:
> On Thu, 1 May 2008, Andrew Morton wrote:
> > >
> > > ...
> > >
> > > --- /dev/null
> > > +++ b/drivers/net/sfc/i2c-direct.h
> > 
> > There is no linkage with the kernel's own i2c layer?  Should there be?
> 
> Last time I checked (i.e. when I originally wrote this bit of the code), 
> the kernel's own i2c layer didn't provide any clean way for kernel code 
> (rather than user code) to access i2c devices.

You may be thinking of the lm87 sensor driver, which exposes its
configuration through sysfs (iirc) and not through specific kernel
functions.  There was an I2C module for EF1 boards that worked with lm87
and the I2C framework, but it was removed along with all EF1 support.
Perhaps I should look at adapting that to the Falcon boards.  We would
still want to do at least the initial programming of the sensors from the
sfc driver though.

> As originally written, there was also a link to the kernel's i2c layer so 
> that the NIC's onboard i2c bus could be exposed to e.g. lm_sensors for 
> temperature monitoring.  I believe that this part of the driver was 
> expunged since it made the patch "too large", but I may be wrong.

The temperature and voltage monitoring was not included.  In the submitted
driver, the I2C code is needed for power control and setting the over-
temperature cut-out value on SFE4001 boards.  These use a MAX6647, not an
LM87.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html