netdev - Re: [PATCH] [NET] warn when accounting an skb that already has a destructor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 May 2008 00:20:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [NET] warn when accounting an skb that already has a
 destructor

From: Johannes Berg <johannes@...solutions.net>
Date: Sun, 04 May 2008 20:32:20 +0200

> This makes the networking layer warn when something tries to
> charge an skb to a socket that already is charged to another
> socket (or has a destructor from somewhere else.)
> 
> Signed-off-by: Johannes Berg <johannes@...solutions.net>

I completely agree that this a correct assertion, that
absolutely should never happen in the current tree.

But if we are going to do this, I'm pretty sure we'll
need to uninline these two routines.

I'll leave it up to you, if you think it's still worthwhile
with the uninlining, please resubmit :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html