netdev - CONFIG_HIGHMEM or CONFIG_HIGHMEM64G in illegal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200805061535.40424.mitov@issp.bas.bg>
Date:	Tue, 6 May 2008 15:35:40 +0300
From:	Marin Mitov <mitov@...p.bas.bg>
To:	linux-kernel@...r.kernel.org
Cc:	netdev@...r.kernel.org
Subject: CONFIG_HIGHMEM or CONFIG_HIGHMEM64G in illegal_highdma()

Hi all,

The usage of NETIF_F_HIGHDMA in net drivers make me think its 
purpose is to declare drivers's capability to address RAM above 4GB, OK?

For x86_64 CONFIG_HIGHMEM is not defined, so the function 
illegal_highdma() found in net/core/dev.c returns 0 because 
x86_64 has IOMMU mapping all RAM.

For x86_32 CONFIG_HIGHMEM is defined as 
(CONFIG_HIGHMEM4G || CONFIG_HIGHMEM64G)
While CONFIG_HIGHMEM4G insures RAM is bellow 4GB some checks
are unnecessarily done. 

Should we have CONFIG_HIGHMEM64G in illegal_highdma()
instead of CONFIG_HIGHMEM?

Regards.

Marin Mitov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html