netdev - Re: New driver "sfc" for Solarstorm SFC4000 controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080506081225.637df034.akpm@linux-foundation.org>
Date:	Tue, 6 May 2008 08:12:25 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: New driver "sfc" for Solarstorm SFC4000 controller.

On Tue, 6 May 2008 16:04:53 +0100 Ben Hutchings <bhutchings@...arflare.com> wrote:

> > or
> > 
> >  	while (*dma_done != FALCON_STATS_DONE) {
> > 		udelay(1);
> > 		if (++timeout > TIMEOUT)
> > 			goto timeout;
> > 	}
>  
> On some architectures udelay() is defined using inline assembly that is not
> specified as clobbering memory.  So the compiler need not reload *dma_done
> after calling it, and this doesn't work.

So pop a cpu_relax() in there as the document describes?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html