netdev - RE: [Bugme-new] [Bug 10600] New: e1000 updates rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 May 2008 10:22:17 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Ben Liblit" <liblit@....org>, "Michael Chan" <mchan@...adcom.com>
Cc:	"David Miller" <davem@...emloft.net>, <akpm@...ux-foundation.org>,
	"netdev" <netdev@...r.kernel.org>,
	<bugme-daemon@...zilla.kernel.org>,
	"Ronciak, John" <john.ronciak@...el.com>
Subject: RE: [Bugme-new] [Bug 10600] New: e1000 updates rx_bytes infrequently

Ben Liblit wrote:
> Michael Chan wrote:
>> "ethtool -C eth0 stats-block-usecs" can be used to control statistics
>> update frequency on most tg3 and bnx2 devices.
> 
> But not on my e1000-driven Intel 82566DC, sadly:
> 
> 	# ethtool -C eth0 stats-block-usecs 50
> 	Cannot get device coalesce settings: Operation not supported
> 
> 	# ethtool -c eth0
> 	Coalesce parameters for eth0:
> 	Cannot get device coalesce settings: Operation not supported

e1000/e1000e already has patches upstream that count bytes and packets
"on the fly" to fix this sort of issue.

see commit:
commit ef90e4eca9fcade05dd03f853df75cf459a75422
Author: Auke Kok <auke-jan.h.kok@...el.com>
Date:   Tue Nov 13 20:49:15 2007 -0800

    [E1000]: update netstats traffic counters realtime

    formerly e1000/e1000e only updated traffic counters once every
    2 seconds with the register values of bytes/packets. With newer
    code however in the interrupt and polling code we can real-time
    fill in these values in the netstats struct for users to see.

    Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

and for e1000e (which you should be using for 82566)
commit 419886927796dfeca87c1fd11d1fe2ed442103cc
Author: Auke Kok <auke-jan.h.kok@...el.com>
Date:   Tue Nov 13 20:48:36 2007 -0800

    [E1000E]: update netstats traffic counters realtime

    formerly e1000/e1000e only updated traffic counters once every
    2 seconds with the register values of bytes/packets. With newer
    code however in the interrupt and polling code we can real-time
    fill in these values in the netstats struct for users to see.

    Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

I'm not sure if this patch is in 2.6.24 and my git foo is lacking... 
is this patch not working for you?  if so we need to figure out why.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html