lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 07 May 2008 19:37:55 +0400 From: Pavel Emelyanov <xemul@...nvz.org> To: Daniel Lezcano <dlezcano@...ibm.com> CC: David Miller <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: [PATCH][NETNS]: Fix arbitrary net_device-s corruptions on net_ns stop. >> + sprintf(fb_name, "dev%d", dev->ifindex); > > The computed interface name can not exceed IFNAMSIZ, 3 ('dev') + 10 (max > int) + 1 ('\0'). In this case there is no risk to corrupt the stack but > may be it is more secure to change that to snprintf(fb_name, IFNAMSIZ, > "dev%d", dev->ifindex), just in case, no ? But you have just noticed, that "there is no risk to corrupt the stack"! What else can be "more secure" then :) ? Thanks, Pavel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists