netdev - Re: [PATCH] Remove cli()/sti() calls from HYSDN driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080508083353.GA18187@pingi.kke.suse.de>
Date:	Thu, 8 May 2008 10:33:53 +0200
From:	Karsten Keil <kkeil@...e.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Mark Asselstine <mark.asselstine@...driver.com>,
	kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
	kkeil@...e.de, asselsm@...il.com
Subject: Re: [PATCH] Remove cli()/sti() calls from HYSDN driver.

On Wed, May 07, 2008 at 03:38:00PM -0700, Andrew Morton wrote:
> On Thu,  1 May 2008 16:16:52 -0400
> Mark Asselstine <mark.asselstine@...driver.com> wrote:
> 
> > >From looking at this driver the use of cli()/sti() within the do/while
> > was a way to ensure interrupts were only disabled for short periods of
> > time while the bulk of the time interrupts were free to occur. The
> > use of the spin lock has eliminated the need to play with interrupts
> > in this way while still allowing for IO to be protected.
> 
> OK.  If we still want the interrupt-latency optimisation then we should
> switch over to using local_irq_disable().  But probably nobody cares.
> 
> > The remaining 3 sti() calls seem unneeded now that at no other point
> > in the driver is there a call to cli().
> > 
> > Signed-off-by: Mark Asselstine <mark.asselstine@...driver.com>
> > ---
> >  drivers/isdn/hysdn/boardergo.c |   14 +++++---------
> 
> So... can we now do this?
> 

I think so.

> 
> --- a/drivers/isdn/hysdn/Kconfig~a
> +++ a/drivers/isdn/hysdn/Kconfig
> @@ -3,7 +3,7 @@
>  #
>  config HYSDN
>  	tristate "Hypercope HYSDN cards (Champ, Ergo, Metro) support (module only)"
> -	depends on m && PROC_FS && PCI && BROKEN_ON_SMP
> +	depends on m && PROC_FS && PCI
>  	help
>  	  Say Y here if you have one of Hypercope's active PCI ISDN cards
>  	  Champ, Ergo and Metro. You will then get a module called hysdn.
> _

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html