lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 8 May 2008 21:32:54 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Michael Buesch <mb@...sch.de>
Cc:	Johannes Berg <johannes@...solutions.net>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Ron Rindjunsky <ron.rindjunsky@...el.com>,
	Tomas Winkler <tomasw@...il.com>,
	Ivo van Doorn <ivdoorn@...il.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH] mac80211: rewrite fragmentation code

On Thu, May 08, 2008 at 03:13:56PM +0200, Michael Buesch wrote:
>
> Ok, why is nobody actually answering my _question_? :)
> So I'll try to answer it by myself: the hard_start_xmit callback
> is actually supposed to return "void", but it returns "int" just
> for historical reasons. So there is no way to fail in a TX handler.

Pretty much.  When lockless drivers were the vogue the return
value was useful but as we've since found better ways to scale
NICs in an SMP environment (first the tg3 model, and then multi-
queue TX) that don't have the problems associated with requeueing
the packet, any non-zero return value should only be used by
existing code.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists