netdev - Re: [PATCH 1/1] [NIU] Redo the fix for getting # of ports from EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080508.172513.01395291.davem@davemloft.net>
Date:	Thu, 08 May 2008 17:25:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Matheos.Worku@....COM
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] [NIU] Redo the fix for getting # of ports from
 EEPROM

From: Matheos Worku <Matheos.Worku@....COM>
Date: Thu, 08 May 2008 17:20:51 -0700

> @@ -8000,6 +7990,11 @@ static int __devinit niu_get_of_props(struct niu *np)
> 
>   	memcpy(dev->dev_addr, dev->perm_addr, dev->addr_len);
> 
> +	model = of_get_property(dp, "model", &prop_len);
> +
> +	if (model)
> +	  strcpy(np->vpd.model, model);
> +

Please fix the indentation in cases like this.  There should
be two tab characters in front of the strcpy().

I don't know what editor you use, but in emacs the editor
can take care of this automatically for you by simply typing
"M-x c-set-style RET linux RET"

I've been fixing up these coding style issues for you in the past, and
I've had to do so for every single patch you send me.  Unfortunately,
it's consuming a lot of my time and I'm not going to do it any more.

Therefore, please have a read up of:

	linux/Documentation/CodingStyle

which should help you in this area.  But generally, if you follow the
existing conventions in the rest of the niu.[ch] files you'll be OK
;-)

Another thing I noticed you do is put two blank lines between
functions, please only use one.

Please also write a full changelog description so people can
understand what you are doing here.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html