netdev - Re: When should kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e5b27790805082355x968c4e3p1d40f3acfec3f123@mail.gmail.com>
Date:	Thu, 8 May 2008 23:55:41 -0700
From:	"Paul Marks" <paul@...rks.net>
To:	"David Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: When should kfree_skb be used?

On Thu, May 8, 2008 at 11:41 PM, David Miller <davem@...emloft.net> wrote:
> From: "Paul Marks" <paul@...rks.net>
> Date: Thu, 8 May 2008 23:34:59 -0700
>
>> I've been looking at more uses of pskb_may_pull(), and almost all of
>> them seem to kfree_skb() after a failure.  Could this occurence in
>> sit.c be a bug?  It looks like this line was added by davem for linux
>> 2.4.4 in 2001, and hasn't changed since.
>
> Yep, looks like a leak.  The following should fix it, thanks
> for the report:
>

Ok, cool, that makes more sense now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html