netdev - Re: [PATCH net-2.6] [TIPC]: Increase buffer headroom to support gianfar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080508.171504.143648405.davem@davemloft.net>
Date:	Thu, 08 May 2008 17:15:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	allan.stephens@...driver.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] [TIPC]: Increase buffer headroom to support
 gianfar

From: Allan Stephens <allan.stephens@...driver.com>
Date: Thu,  8 May 2008 20:07:55 -0400

> This patch increases the headroom TIPC reserves in each sk_buff
> to 24 bytes, due to the 8 byte FCB used by gianfar.
> 
> Signed-off-by: Allan Stephens <allan.stephens@...driver.com>

This is not how this is computed.

Please use LL_RESERVED_SPACE() like every other packet output
path does.  Or, at a minimum, reserve LL_MAX_HEADER bytes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html