netdev - Re: [PATCH -next] net: hso driver uses rfkill functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 May 2008 11:29:20 +0300
From:	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	netdev <netdev@...r.kernel.org>, ajb@...eresystems.co.uk,
	jgarzik <jgarzik@...ox.com>, akpm <akpm@...ux-foundation.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH -next] net: hso driver uses rfkill functions

AFAIK Greg has (or he is going to do it) patch for rfkill so no more 
depends or select RFKILL will be needed.

BR,
Paulius Zaleckas

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> hso driver uses rfkill functions so should either depend on RFKILL
> or select it.  This patch uses depends on RFKILL.
> 
> drivers/built-in.o: In function `hso_disconnect':
> hso.c:(.text+0x868c9): undefined reference to `rfkill_unregister'
> drivers/built-in.o: In function `hso_probe':
> hso.c:(.text+0x88226): undefined reference to `rfkill_allocate'
> hso.c:(.text+0x8829e): undefined reference to `rfkill_register'
> hso.c:(.text+0x8860f): undefined reference to `rfkill_free'
> make[1]: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/net/usb/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- next-20080509.orig/drivers/net/usb/Kconfig
> +++ next-20080509/drivers/net/usb/Kconfig
> @@ -156,7 +156,7 @@ config USB_NET_AX8817X
>  
>  config USB_HSO
>  	tristate "Option USB High Speed Mobile Devices"
> -	depends on USB
> +	depends on USB && RFKILL
>  	default n
>  	help
>  	  Choose this option if you have an Option HSDPA/HSUPA card.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html